(PC-29215)[API] feat: split films, series, cinema search group #13956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thconte
force-pushed
the
pc-29215-add-new-cine-search-groups
branch
3 times, most recently
from
0b3524f
to
a42ded5
Compare
lixxday
approved these changes
Sep 6, 2024
| @@ -192,17 +192,17 @@ def get_show_nodes() -> list[ShowGenre]: | |||
| SEARCH_GROUP_ARTS_LOISIRS_CREATIFS = SearchGroup( | |||
| technical_name="ARTS_LOISIRS_CREATIFS", | |||
| label="Arts & loisirs créatifs", | |||
| position=5, | |||
| position=6, | |||
There was a problem hiding this comment.
❔ question: par curiosité, comment on choisit la valeur de position ?
low logaf
There was a problem hiding this comment.
C'est les UX qui décident.
L'ancien search group était en 2, et on veut mettre les deux qui le remplacent au même endroit, donc positions 2 et 3, donc ça décale le reste de 1.
Pour vérifier qu'on fait pas de bêtise, c'est bien de tester en local et de comparer à la prod.
Je pourrai rajouter un screenshot, mais l'app ne prend pas encore en compte ces données-là (WIP).
cepehang
approved these changes
Sep 6, 2024
thconte
force-pushed
the
pc-29215-add-new-cine-search-groups
branch
from
a42ded5
to
418bfc1
Compare
thconte
force-pushed
the
pc-29215-add-new-cine-search-groups
branch
3 times, most recently
from
bc27b9a
to
7cc1987
Compare
thconte
force-pushed
the
pc-29215-add-new-cine-search-groups
branch
from
7cc1987
to
15a7e1c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
But de la pull request
Ticket Jira (ou description si BSR) : https://passculture.atlassian.net/browse/PC-29215
Vérifications